Monkey patch GUI elements #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @pmrv |
pmrv
requested changes
Jul 29, 2022
pyiron_gui/monkey_patching.py
Outdated
Comment on lines
30
to
35
| if hasattr(cls, attr_name): | ||
| warnings.warn( | ||
| f"Class {cls.__name__} already has attribute {attr_name} - Aborting monkey path of gui elements." | ||
| ) | ||
| else: | ||
| setattr(cls, attr_name, value) |
There was a problem hiding this comment.
This might break in a similar way under reloading module has @jan-janssen pointed out in pyiron_base#808. I discussed a potential fix there also.
Co-authored-by: Marvin Poul <[email protected]>
niklassiemer
commented
Aug 17, 2022
niklassiemer
added
format_black
|
@pmrv I now think this should be absolutely safe to reload. |
Co-authored-by: Marvin Poul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.